Attempt to fix flaky burn rate test#212039
Merged
maryam-saeidi merged 2 commits intoelastic:mainfrom Feb 25, 2025
Merged
Conversation
maryam-saeidi
added
release_note:skip
Contributor
💚 Build Succeeded
Metrics [docs]
|
Contributor
|
@maryam-saeidi Did you run this against flaky test runner? |
Member
Author
No, I didn't think it was necessary, as the issue only happened a few times. Recently, I fixed some minor issues for the tests that failed very few times, so I didn't run the flaky test runner for them. Let me know if you think it would be useful to run it. |
This was referenced Feb 25, 2025
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
Fixes elastic#211439 ## Summary @simianhacker pointed out that the `alignEventsToInterval` setting aligns the data generation so that we have the exact number of documents in each bucket; I noticed this setting is missing for the burn rate rule test. ### How to run the test ``` // Server node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts // Test node scripts/functional_test_runner --config=x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="Burn rate rule" ``` Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
Fixes elastic#211439 ## Summary @simianhacker pointed out that the `alignEventsToInterval` setting aligns the data generation so that we have the exact number of documents in each bucket; I noticed this setting is missing for the burn rate rule test. ### How to run the test ``` // Server node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts // Test node scripts/functional_test_runner --config=x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="Burn rate rule" ``` Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211439
Summary
@simianhacker pointed out that the
alignEventsToIntervalsetting aligns the data generation so that we have the exact number of documents in each bucket; I noticed this setting is missing for the burn rate rule test.How to run the test